fix ci for release #101

Merged
marfavi merged 3 commits from ci/forgejo-artifact-actions into main 2026-10-30 15:03:59 +01:00
Owner
No description provided.
The macOS job runs on the Mac itself, not in a container, and its artifact
upload has failed once with

  Failed to CreateArtifact: Unable to make request: ETIMEDOUT

while the identical call from the Docker runner had just succeeded - the
host has no usable IPv6 path although git.marfavi.com publishes AAAA
records, and a dropped connection to the forge costs the whole release.

Resolve to IPv4 for this job and retry the upload once, replacing the
half-created artifact a failed first attempt may leave behind.

(cherry picked from commit 04b43ace7a)
fix(package): keep the host-built tree-sitter addon out of the VSIX
Some checks failed
Grammar / Corpus and binding tests (pull_request) Successful in 55s
Extension / Format, types, lint, extension tests (pull_request) Failing after 1m12s
dc04c897f9
The packaging job runs `npm ci` on the packaging host, which leaves a
`build/Release/tree_sitter_runtime_binding.node` for that host in
`node_modules/tree-sitter`. `prebuild-native.mjs` pruned `build/` from
`tree-sitter-crocq` but not from `tree-sitter`, so the VSIX shipped the
Linux/arm64 addon built in the container.

`node-gyp-build` prefers `build/Release/*.node` over `prebuilds/`, so the
extension host on macOS tried to dlopen an ELF file and threw before
`activate()` could register anything: the commands appeared in the palette
but failed with "command not found", and the views had no provider.

Prune both packages, and make the release verification fail when any .node
is packaged outside `prebuilds/` instead of trusting the prune list.

(cherry picked from commit 5376002a94)
marfavi scheduled this pull request to auto merge when all checks succeed 2026-10-30 14:54:08 +01:00
michael approved these changes 2026-10-30 14:54:14 +01:00
fix(package): prune tree-sitter's build/ only when packaging
All checks were successful
Grammar / Corpus and binding tests (pull_request) Successful in 1m11s
Extension / Format, types, lint, extension tests (pull_request) Successful in 2m46s
d63a7c6053
Pruning it unconditionally broke the extension job: the prebuild shipped by
the `tree-sitter` package needs GLIBCXX_3.4.31, which the CI image (Ubuntu
22.04, libstdc++ 12) does not provide, so the addon compiled by `npm ci` in
`node_modules/tree-sitter/build` is the only one that loads there. Since
`npm run prebuild:native` is a CI step, it has to keep that copy - pruning it
made the unit tests fail with ERR_DLOPEN_FAILED.

Drop it only for the packaging run, signalled by CROCQ_PACKAGING=1 from
`vscode:prepublish`, so the VSIX never contains the packaging host's addon.

(cherry picked from commit a6fca6d106)
marfavi deleted branch ci/forgejo-artifact-actions 2026-10-30 15:04:00 +01:00
marfavi referenced this pull request from a commit 2026-10-30 15:04:00 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code2rocq/crocq!101
No description provided.