Add force option for generating proof files #80

Merged
marfavi merged 10 commits from feature/allow-force-creating-templates-for-files-that-already-exist into main 2026-10-29 13:38:32 +01:00
Owner

fixes #65

fixes #65
tweaked to not use vscode types
Some checks failed
Grammar / Corpus and binding tests (pull_request) Successful in 45s
Extension / Format, types, lint, extension tests (pull_request) Failing after 57s
1bc6e0688d
Use the injected quick pick service in createProofFiles
All checks were successful
Grammar / Corpus and binding tests (pull_request) Successful in 42s
Extension / Format, types, lint, extension tests (pull_request) Successful in 1m54s
f085dc0779
The command imported showQuickPick from commands/services/messages, which
imports the vscode module at load time. Unit tests run the compiled command
under plain mocha, where vscode does not exist, so the whole suite failed with
MODULE_NOT_FOUND. Call the showQuickPick service that CreateProofFileServices
already declares, which is what the unit test stub provides.

Also cover the new prompt: declining overwrites nothing, accepting overwrites,
cancelling stops the run, and the force argument skips the prompt.
Added seperate command that forces generation of all proof files (even if they already exist)
All checks were successful
Grammar / Corpus and binding tests (pull_request) Successful in 1m5s
Extension / Format, types, lint, extension tests (pull_request) Successful in 2m39s
bca2f37932
michael changed title from WIP: feature/allow-force-creating-templates-for-files-that-already-exist to feature/allow-force-creating-templates-for-files-that-already-exist 2026-10-28 15:07:49 +01:00
marfavi changed title from feature/allow-force-creating-templates-for-files-that-already-exist to Add force option for generating proof files 2026-10-28 15:09:16 +01:00
Merge branch 'main' into feature/allow-force-creating-templates-for-files-that-already-exist
All checks were successful
Grammar / Corpus and binding tests (pull_request) Successful in 42s
Extension / Format, types, lint, extension tests (pull_request) Successful in 2m24s
24ef784285
marfavi requested changes 2026-10-28 15:20:03 +01:00
Dismissed
marfavi left a comment

Small requests

Small requests
@ -42,1 +42,4 @@
},
{
"command": "crocq.createProofFiles.force",
"title": "Crocq: Create proof files for project (force)"
Owner

UX: use more warning-y language for destructive action

(force) -> (overwrite existing)

UX: use more warning-y language for destructive action ~(force)~ -> (overwrite existing)
michael marked this conversation as resolved
@ -16,1 +17,4 @@
export const ALL_PROOF_FILES = 'all';
const FORCE_QUICK_PICK_OPTIONS = [
'Only create non existing files',
'Override already existing files',
Owner

Spelling: Override already existing files -> Overwrite existing files

Spelling: ~Override already existing files~ -> Overwrite existing files
Owner

UX: Add as secondary text "Overwrites file1.v, file2.v & 5 other files" (probably requires us to use VsCode class instead of string). You can create a separate issue for this.

UX: Add as secondary text "Overwrites file1.v, file2.v & 5 other files" (probably requires us to use VsCode class instead of string). You can create a separate issue for this.
michael marked this conversation as resolved
Made the fact the command might overwrite data more clear
All checks were successful
Grammar / Corpus and binding tests (pull_request) Successful in 51s
Extension / Format, types, lint, extension tests (pull_request) Successful in 2m3s
39d5e6b501
Improved naming of quick pick option
All checks were successful
Grammar / Corpus and binding tests (pull_request) Successful in 43s
Extension / Format, types, lint, extension tests (pull_request) Successful in 2m8s
ea878fc8a2
Merge branch 'main' into feature/allow-force-creating-templates-for-files-that-already-exist
All checks were successful
Grammar / Corpus and binding tests (pull_request) Successful in 41s
Extension / Format, types, lint, extension tests (pull_request) Successful in 1m54s
218d889189
marfavi approved these changes 2026-10-29 13:36:39 +01:00
marfavi scheduled this pull request to auto merge when all checks succeed 2026-10-29 13:36:46 +01:00
marfavi deleted branch feature/allow-force-creating-templates-for-files-that-already-exist 2026-10-29 13:38:32 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code2rocq/crocq!80
No description provided.